Properly terminate functions. Cache selectors in variables. Reformating dashboard JS.

static/js/dashboard.js

@@ -59,7 +59,7 @@ jQuery.extend(jQuery.fn.dataTableExt.oSort, {
         //
         function zeroPad(num, places) {
             var zero = places - num.toString().length + 1;
-            return Array(+(zero > 0 && zero)).join("0") + num;
+            return new Array(+(zero > 0 && zero)).join("0") + num;
         }
 
         // build the resulting IP
@@ -99,29 +99,35 @@ function get_os_data(url, element) {
 
 var dashboard = {};
 
-
 dashboard.getUptime = function () {
     get_os_data('/info/uptime/', "#get-uptime");
-        }
+};
+
 dashboard.getOSname = function () {
     get_os_data('/info/platform/osname/', "#get-osname");
-        }
+};
+
 dashboard.getHostname = function () {
     get_os_data('/info/platform/hostname/', "#get-hostname");
-        }
+};
+
 dashboard.getKernel = function () {
     get_os_data('/info/platform/kernel/', "#get-kernel");
-        }
+};
+
 dashboard.getCPUcount = function () {
     get_os_data('/info/getcpus/count/', "#get-cpucount");
-        }
+};
+
 dashboard.getCPUtype = function () {
     get_os_data('/info/getcpus/type/', "#get-cputype");
-        }
+};
+
 dashboard.getDisk = function () {
     $.getJSON('/info/getdisk/', function (data) {
         destroy_dataTable("get_disk");
-            $("#filter-ps").val("").off("keyup");
+        var $filterPs = $("#filter-ps");
+        $filterPs.val("").off("keyup");
         var psTable = $("#get_disk").dataTable({
             aaData: data,
             aoColumns: [
@@ -138,15 +144,17 @@ dashboard.getDisk = function() {
             bAutoWidth: false,
             bInfo: false
         }).fadeIn();
-            $("#filter-ps").on("keyup", function() {
+        $filterPs.on("keyup", function () {
             psTable.fnFilter(this.value);
         });
     });
-}
+};
+
 dashboard.getUsers = function () {
     $.getJSON('/info/getusers/', function (data) {
         destroy_dataTable("get_users");
-            $("#filter-ps").val("").off("keyup");
+        var $filterPs = $("#filter-ps");
+        $filterPs.val("").off("keyup");
         var psTable = $("#get_users").dataTable({
             aaData: data,
             aoColumns: [
@@ -164,15 +172,17 @@ dashboard.getUsers = function() {
             bAutoWidth: false,
             bInfo: false
         }).fadeIn();
-            $("#filter-ps").on("keyup", function() {
+        $filterPs.on("keyup", function () {
             psTable.fnFilter(this.value);
         });
     });
-}
+};
+
 dashboard.getNetstat = function () {
     $.getJSON('/info/getnetstat/', function (data) {
         destroy_dataTable("get_netstat");
-            $("#filter-ps").val("").off("keyup");
+        var $filterPs = $("#filter-ps");
+        $filterPs.val("").off("keyup");
         var psTable = $("#get_netstat").dataTable({
             aaData: data,
             aoColumns: [
@@ -188,15 +198,17 @@ dashboard.getNetstat = function() {
             bAutoWidth: false,
             bInfo: false
         }).fadeIn();
-            $("#filter-ps").on("keyup", function() {
+        $filterPs.on("keyup", function () {
             psTable.fnFilter(this.value);
         });
     });
-}
+};
+
 dashboard.getProc = function () {
     $.getJSON('/info/proc/', function (data) {
         destroy_dataTable("get_proc");
-            $("#filter-ps").val("").off("keyup");
+        var $filterPs = $("#filter-ps");
+        $filterPs.val("").off("keyup");
         var psTable = $("#get_proc").dataTable({
             aaData: data,
             aoColumns: [
@@ -219,16 +231,17 @@ dashboard.getProc = function() {
             bAutoWidth: false,
             bInfo: false
         }).fadeIn();
-            $("#filter-ps").on("keyup", function() {
+        $filterPs.on("keyup", function () {
             psTable.fnFilter(this.value);
         });
     });
-}
+};
 
 dashboard.getIps = function () {
     $.getJSON('/info/getips/', function (data) {
         destroy_dataTable("get_ips");
-            $("#filter-ps").val("").off("keyup");
+        var $filterPs = $("#filter-ps");
+        $filterPs.val("").off("keyup");
         var psTable = $("#get_ips").dataTable({
             aaData: data,
             aoColumns: [
@@ -244,17 +257,16 @@ dashboard.getIps = function() {
             bAutoWidth: false,
             bInfo: false
         }).fadeIn();
-            $("#filter-ps").on("keyup", function() {
+        $filterPs.on("keyup", function () {
             psTable.fnFilter(this.value);
         });
     });
-}
+};
 
 // Expand-Contract div/table
 $(document).ready(function () {
     $(".widget-content").show();
-    $(".widget-header").click(function()
-    {
+    $(".widget-header").click(function () {
         $(this).next(".widget-content").slideToggle(500);
         $("i", this).toggleClass("icon-minus icon-plus");
     });