Browse Source

Ensured the browser session doesn't auto close when interpreter exits.

master
Raphael Roberts 7 years ago
parent
commit
e370fa2463
  1. 5
      restscrape/scraping/browser.py

5
restscrape/scraping/browser.py

@ -21,10 +21,10 @@ class BrowserConnection:
self.browser_handle: pyppeteer.browser.Browser = run( self.browser_handle: pyppeteer.browser.Browser = run(
pyppeteer.launcher.connect(browserWSEndpoint=address) pyppeteer.launcher.connect(browserWSEndpoint=address)
) )
self.address = browser_handle.address
elif address is None: elif address is None:
self.browser_handle = browser_handle self.browser_handle = browser_handle
self.address = browser_handle.wsEndpoint
self.address = self.browser_handle.wsEndpoint
def create_tab(self): def create_tab(self):
return Tab(self.browser_handle) return Tab(self.browser_handle)
@ -55,6 +55,7 @@ class Tab:
def start_browser(proxy=None, use_adblock=True, **launch_opts): def start_browser(proxy=None, use_adblock=True, **launch_opts):
opts = launch_opts opts = launch_opts
opts["autoClose"] = False
if use_adblock: if use_adblock:
adblock_path = Path(__file__).parent / "uBlock" adblock_path = Path(__file__).parent / "uBlock"
opts.setdefault("args", []).extend( opts.setdefault("args", []).extend(

Loading…
Cancel
Save