From e370fa24630442e8581673baf552e74e65c1b184 Mon Sep 17 00:00:00 2001 From: Raphael Roberts Date: Fri, 31 May 2019 12:35:23 -0500 Subject: [PATCH] Ensured the browser session doesn't auto close when interpreter exits. --- restscrape/scraping/browser.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/restscrape/scraping/browser.py b/restscrape/scraping/browser.py index 5fbc7e9..0259612 100644 --- a/restscrape/scraping/browser.py +++ b/restscrape/scraping/browser.py @@ -21,10 +21,10 @@ class BrowserConnection: self.browser_handle: pyppeteer.browser.Browser = run( pyppeteer.launcher.connect(browserWSEndpoint=address) ) - self.address = browser_handle.address elif address is None: self.browser_handle = browser_handle - self.address = browser_handle.wsEndpoint + + self.address = self.browser_handle.wsEndpoint def create_tab(self): return Tab(self.browser_handle) @@ -55,6 +55,7 @@ class Tab: def start_browser(proxy=None, use_adblock=True, **launch_opts): opts = launch_opts + opts["autoClose"] = False if use_adblock: adblock_path = Path(__file__).parent / "uBlock" opts.setdefault("args", []).extend(